Integration federation lookup module #2226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nqhhdev
commented
Feb 4, 2025
•
nqhhdev
commented
- Setup module: Federation lookup
- Setup module: Federation request token
nqhhdev
requested review from
hoangdat,
dab246 and
tddang-linagora
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2226 |
hoangdat
reviewed
Feb 5, 2025
| ); | ||
|
|
||
| if (registerResponse.token == null && registerResponse.token!.isEmpty) { | ||
| yield const Left(FederationIdentityGetTokenFailure()); |
There was a problem hiding this comment.
Suggested change
| yield const Left(FederationIdentityGetTokenFailure()); | |
| yield const Left(FederationIdentityRegisterAccountFailure(identityServer)); |
hoangdat
reviewed
Feb 5, 2025
Comment on lines
+47
to
+52
| class FederationIdentityGetTokenFailure extends Failure { | ||
| const FederationIdentityGetTokenFailure(); | ||
|
|
||
| @override | ||
| List<Object?> get props => []; | ||
| } |
There was a problem hiding this comment.
Suggested change
| class FederationIdentityGetTokenFailure extends Failure { | |
| const FederationIdentityGetTokenFailure(); | |
| @override | |
| List<Object?> get props => []; | |
| } | |
| class FederationIdentityRegisterAccountFailure extends Failure { | |
| const FederationIdentityRegisterAccountFailure(idenityServer); | |
| final identityServer; | |
| @override | |
| List<Object?> get props => []; | |
| } |
hoangdat
reviewed
Feb 5, 2025
| yield const Left(FederationIdentityGetTokenFailure()); | ||
| } | ||
|
|
||
| final hashDetails = |
There was a problem hiding this comment.
should verify hashDetails response
hoangdat
reviewed
Feb 5, 2025
|
|
||
| final FederationTokenInformation tokenInformation; | ||
|
|
||
| final Set<String>? phoneNumbers; |
There was a problem hiding this comment.
Suggested change
| final Set<String>? phoneNumbers; | |
| final Map<ContactId, Set<String>>? phoneNumbers; |
hoangdat
reviewed
Feb 5, 2025
|
|
||
| final Set<String>? phoneNumbers; | ||
|
|
||
| final Set<String>? emailAddresses; |
There was a problem hiding this comment.
Suggested change
| final Set<String>? emailAddresses; | |
| final Map<ContactId, Set<String>>? emailAddresses; |
hoangdat
reviewed
Feb 5, 2025
| ); | ||
| } | ||
|
|
||
| Stream<Either<Failure, Success>> execute() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.