Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using the whole dataset for inference unless overriden #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtauraso
Copy link
Collaborator

@mtauraso mtauraso commented Jan 10, 2025

See discussion on Issue #138 This implements @drewoldag 's suggestion.

@mtauraso mtauraso linked an issue Jan 10, 2025 that may be closed by this pull request
Copy link

Before [9d1fb12] After [2d5c1ac] Ratio Benchmark (Parameter)
1.73±0.4s 2.99±0.1s ~1.73 benchmarks.time_computation
1.31k 824 0.63 benchmarks.mem_list

Click here to view all benchmarks.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.63%. Comparing base (aaccba0) to head (8831dae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   39.64%   39.63%   -0.02%     
==========================================
  Files          23       23              
  Lines        1844     1847       +3     
==========================================
+ Hits          731      732       +1     
- Misses       1113     1115       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the need to define a split when running predict
2 participants