Being more explicit with the import of importlib.util. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 38.93% 38.99% +0.06%
==========================================
Files 23 23
Lines 1983 1985 +2
==========================================
+ Hits 772 774 +2
Misses 1211 1211 ☔ View full report in Codecov by Sentry. |
mtauraso
reviewed
Jan 23, 2025
| @@ -155,7 +156,7 @@ def _find_external_library_default_config_paths(runtime_config: dict) -> set: | |||
| else: | |||
| if key == "name" and "." in value: | |||
| external_library = value.split(".")[0] | |||
| if importlib.util.find_spec(external_library) is not None: | |||
There was a problem hiding this comment.
OK that is really weird.
There was a problem hiding this comment.
I wonder if some package deep in fibad or KBMOD's dep tree is conditionally replacing functions in importlib.util?
There was a problem hiding this comment.
When we start python on the command line and run the following on baldur in an environment that shares a kbmod installation
>>> import importlib
>>> importlib.ut <attempt tab complete, nothing happens>
>>> importlib.util
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: module 'importlib' has no attribute 'util'
It does seem unpleasant, but it seems to work.
Outside of a KBMOD environment, there's no problem with:
>>> import importlib
>>> importlib.util
mtauraso
approved these changes
Jan 23, 2025
drewoldag
added a commit
that referenced
this pull request
Jan 24, 2025
* Being more explicit with the import of importlib.util. * Importing importlib.util in the one other place it is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to address the issue that was raised in issue #108. Still not immediately clear why this is sometimes an issue, but it seems to be.