Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configs for retries, retrywait, timeout, and chunksize #41

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mtauraso
Copy link
Collaborator

Pretty straightforward addition of these configs with documentation.

@mtauraso mtauraso requested a review from drewoldag August 22, 2024 23:20
@mtauraso mtauraso self-assigned this Aug 22, 2024
@mtauraso mtauraso linked an issue Aug 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.15%. Comparing base (161b806) to head (b76b66c).
Report is 1 commits behind head on main.

Files Patch % Lines
src/fibad/download.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   28.15%   28.15%           
=======================================
  Files          14       14           
  Lines         341      341           
=======================================
  Hits           96       96           
  Misses        245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [161b806] After [5f8b28c] Ratio Benchmark (Parameter)
2.37±0.9s 942±900ms ~0.40 benchmarks.time_computation
3.84k 504 0.13 benchmarks.mem_list

Click here to view all benchmarks.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. One small question, not a blocker.

@mtauraso mtauraso merged commit cab9515 into main Aug 23, 2024
8 of 9 checks passed
@mtauraso mtauraso deleted the issue/40/add-download-configs branch August 23, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface more download parameters to fibad config
2 participants