Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov #79

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Fix codecov #79

merged 5 commits into from
Jan 22, 2025

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jan 22, 2025

codecov has not been reporting properly for awhile, tracked it down to when we change the package name the workflow was not updated appropriately. A few commits of trial and error, but will squash and merge on merge

Copy link

github-actions bot commented Jan 22, 2025

Before [9656c43] <v0.3.1> After [34b155f] Ratio Benchmark (Parameter)
137M 137M 1 benchmarks.NestedFrameAddNested.peakmem_run
268±1ms 268±1ms 1 benchmarks.NestedFrameAddNested.time_run
138M 138M 1 benchmarks.NestedFrameQuery.peakmem_run
827±2ms 828±6ms 1 benchmarks.NestedFrameQuery.time_run
135M 135M 1 benchmarks.NestedFrameReduce.peakmem_run
280±2ms 279±1ms 1 benchmarks.NestedFrameReduce.time_run

Click here to view all benchmarks.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9656c43). Learn more about missing BASE report.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage        ?   95.45%           
=======================================
  Files           ?        9           
  Lines           ?      242           
  Branches        ?        0           
=======================================
  Hits            ?      231           
  Misses          ?       11           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review January 22, 2025 19:48
@dougbrn dougbrn requested a review from hombit January 22, 2025 19:51
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dougbrn dougbrn merged commit 3587556 into main Jan 22, 2025
9 checks passed
@dougbrn dougbrn deleted the fix_codecov_integration branch January 22, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants