Update to use linkedin/go-zk #820
Merged
+19
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trvrnrth
commented
Jun 13, 2024
| @@ -36,12 +35,7 @@ type BurrowZookeeperClient struct { | |||
| // timeout it's possible to reestablish a connection to a different server and keep the same session. This is means any | |||
| // ephemeral nodes and watches are maintained. | |||
| func ZookeeperConnect(servers []string, sessionTimeout time.Duration, logger *zap.Logger) (protocol.ZookeeperClient, <-chan zk.Event, error) { | |||
| // We need a function to set the logger for the ZK connection | |||
There was a problem hiding this comment.
go-zk now uses slog
|
Is there a reason why this has not been reviewed/merged yet? I think we are bumping into the same thing. |
trvrnrth
commented
Jan 25, 2025
| github.com/spf13/viper v1.18.2 | ||
| github.com/stretchr/testify v1.9.0 | ||
| github.com/prometheus/client_golang v1.20.5 | ||
| github.com/samuel/go-zookeeper v0.0.0-20201211165307-7117e9ea2414 |
There was a problem hiding this comment.
This package should no longer be required.
|
@bai Thanks for getting this included. It just needs a |
|
Thanks for your contribution! Will fix that in #837 in a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary driver behind this is to be able to make use of the new default host provider added in linkedin/go-zk#6 to resolve connection issues when zookeeper host IPs change.