[Coral-Trino] Fix substring start index issue #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljfgem
changed the title
ljfgem
reviewed
Mar 15, 2024
coral-trino/src/main/java/com/linkedin/coral/trino/rel2trino/CoralToTrinoSqlCallConverter.java
Outdated
Show resolved
Hide resolved
coral-trino/src/test/java/com/linkedin/coral/trino/rel2trino/RelToTrinoConverterTest.java
Show resolved
Hide resolved
wmoustafa
reviewed
Mar 26, 2024
coral-trino/src/test/java/com/linkedin/coral/trino/rel2trino/HiveToTrinoConverterTest.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/linkedin/coral/common/transformers/JsonTransformSqlCallTransformer.java
Outdated
Show resolved
Hide resolved
wmoustafa
reviewed
Apr 7, 2024
| @@ -135,7 +125,7 @@ protected SqlCall transform(SqlCall sqlCall) { | |||
| new GenericCoralRegistryOperatorRenameSqlCallTransformer(), | |||
|
|
|||
| new ReturnTypeAdjustmentTransformer(configs), new UnnestOperatorTransformer(), new AsOperatorTransformer(), | |||
| new JoinSqlCallTransformer(), new NullOrderingTransformer()); | |||
| new JoinSqlCallTransformer(), new NullOrderingTransformer(), new SubstrIndexTransformer()); | |||
There was a problem hiding this comment.
Could you make sure every transformer is added in a new line?
There was a problem hiding this comment.
spotlessApply forces this formatting
ljfgem
reviewed
Apr 11, 2024
...no/src/main/java/com/linkedin/coral/trino/rel2trino/transformers/SubstrIndexTransformer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
#434 suggested that Hive
substringfunction start index is 0-based, while Trino is 1-based. Upon further investigation, we found that both Hive and Trino indexes are actually 1-based (this was the behavior before #434). The only difference is that Hive also allows 0 as a starting substring index and treats it as 1 (this was not the behavior before #434, where 0 in Hive simply mapped to 0 in Trino). #434 was reverted in #492 but the revert was released in a hot fix branch. This PR corrects the behavior to the expected semantics.To fix this, when translating from Hive to Trino, we ensure that if the hive starting substring index is 0, we change it to 1, while leaving any other index number the same. Use
CASE WHENif start index is another column (we don't know the actual value).How was this patch tested?
./gradlew build
updated + New unit tests
regression tests pending, Update: all regressions expected