[duckdb] Changed DuckDB dep to be a snapshot #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because DuckDB 0.9.0..1.2.0 has a regression where it cannot run in the same JVM that also depends on RocksJava. This has been fixed but is not released yet. When release 1.2.0 comes out, we will be able to remove the snapshot dependency and repository. Miscellaneous: - Bumped up the timeout on DuckDBDaVinciRecordTransformerIntegrationTest - Created a new 1001 integration tests bucket for Duck DVRT, and moved the (regular) DVRT tests to bucket 1000.
ZacAttack
approved these changes
Jan 16, 2025
kvargha
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because DuckDB 0.9.0..1.2.0 has a regression where it cannot run in the same JVM that also depends on RocksJava. This has been fixed but is not released yet. When release 1.2.0 comes out, we will be able to remove the snapshot dependency and repository.
Miscellaneous:
Bumped up the timeout on DuckDBDaVinciRecordTransformerIntegrationTest
Created a new 1001 integration tests bucket for Duck DVRT, and moved the (regular) DVRT tests to bucket 1000.
Works around duckdb/duckdb-java#14
Does this PR introduce any user-facing changes?