-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v5.12.0 #368
Merged
Merged
Release v5.12.0 #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 📝 Description **What does this PR do and why is this change necessary?** Add support for `nodebalancers/{nb_id}/firewalls` endpoint ## ✔️ How to Test **How do I run the relevant unit/integration tests?** ```bash make testunit ```
… LinodeClient.load(...) (#359) * Fix issue that prevent LinodeClient.load(...) from working with LKENodePool * make format
* update legacy regions with new compute regions * update volume region for test_attach_volume_to_linode
--------- Co-authored-by: Ania Misiorek <[email protected]> Co-authored-by: Ania Misiorek <[email protected]>
…ory (#366) * move test upload logic to git submodule, and use it in e2e workflow * update script folder name * checkout submodule in workflow * change submodule name
zliang-akamai
requested review from
lgarber-akamai and
yec-akamai
and removed request for
a team
January 8, 2024 16:21
lgarber-akamai
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
yec-akamai
approved these changes
Jan 8, 2024
…valid labels (#367) * move test upload logic to git submodule, and use it in e2e workflow * update script folder name * migrate g5 to g6 and fix label too long error in tests * remove test script folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.