Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented changes for VPU #485

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Added support for new VPU fields and added tests.

✔️ How to Test

The following assumes you have pulled down this PR locally.

Unit Tests

make testunit

Integration Tests

make TEST_CASE="test_get_linode_types" testint
make TEST_CASE="test_get_vpu" testint
make TEST_CASE="test_create_vpu" testint

@ezilber-akamai ezilber-akamai marked this pull request as ready for review December 13, 2024 19:54
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner December 13, 2024 19:54
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team December 13, 2024 19:54
@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Dec 20, 2024
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests all passing locally! Great work!

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tests work once you update the image.

test/integration/models/linode/test_linode.py Outdated Show resolved Hide resolved
@ezilber-akamai ezilber-akamai merged commit d8bc120 into linode:dev Jan 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants