Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Nodebalancers UDP #494

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Added support for Nodebalancers UDP and corresponding tests.

✔️ How to Test

Pull down this PR locally before running tests.

Unit Tests

make testunit

Integration Tests

make TEST_CASE="test_create_nb" testint
make TEST_CASE="test_get_nb_config_with_udp" testint
make TEST_CASE="test_update_nb_config" testint
make TEST_CASE="test_get_nb" testint
make TEST_CASE="test_update_nb" testint

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner January 8, 2025 18:24
@ezilber-akamai ezilber-akamai requested review from lgarber-akamai and yec-akamai and removed request for a team January 8, 2025 18:24
@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Jan 8, 2025
@ezilber-akamai ezilber-akamai force-pushed the TPT-3379-support-nodebalancers-udp branch from 0a25827 to 1c51a3f Compare January 8, 2025 18:41
@ezilber-akamai ezilber-akamai marked this pull request as draft January 8, 2025 19:17
@ezilber-akamai ezilber-akamai force-pushed the TPT-3379-support-nodebalancers-udp branch from 1912c19 to fae511e Compare January 13, 2025 15:50
@ezilber-akamai ezilber-akamai force-pushed the TPT-3379-support-nodebalancers-udp branch from fae511e to fcfcd1b Compare January 13, 2025 15:52
@ezilber-akamai ezilber-akamai added new-feature for new features in the changelog. and removed improvement for improvements in existing functionality in the changelog. labels Jan 13, 2025
@ezilber-akamai ezilber-akamai marked this pull request as ready for review January 13, 2025 15:55
@ezilber-akamai ezilber-akamai force-pushed the TPT-3379-support-nodebalancers-udp branch from 9b95bb0 to 06356a9 Compare January 14, 2025 19:18
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my end, great work!

@ezilber-akamai ezilber-akamai changed the base branch from dev to proj/nb-udp January 16, 2025 15:26
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ezilber-akamai ezilber-akamai merged commit 2d23cef into linode:proj/nb-udp Jan 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants