Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Support deleting IP address #497

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

yec-akamai
Copy link
Contributor

📝 Description

Allow user to use ip.delete() when they want to delete a public or private IPv4 address associated with a Linode. This will fail if it is the Linode's last remaining public IPv4 address, or if the address has a 1:1 NAT with an active VPC Subnet address.

It overrides the delete() function from base to adapt the correct endpoint for IPAddress.

✔️ How to Test

make testunit
make TEST_CASE="test_allocate_and_delete_ip -vvv" testint

@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Jan 17, 2025
@yec-akamai yec-akamai requested a review from a team as a code owner January 17, 2025 20:54
@yec-akamai yec-akamai requested review from jriddle-linode and ezilber-akamai and removed request for a team January 17, 2025 20:54
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests are passing localy. Nice work!

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

@yec-akamai yec-akamai merged commit e2e9343 into linode:dev Jan 23, 2025
12 checks passed
@yec-akamai yec-akamai deleted the TPT-3401/delete-ip branch January 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants