Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Support deleting VLAN in networking group #500

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

yec-akamai
Copy link
Contributor

📝 Description

Allow user to delete a VLAN using networking.delete_vlan(). Note that a VLAN can't be deleted if it's still attached to a Linode.

✔️ How to Test

make testunit
make TEST_CASE="test_create_and_delete_vlan -v" testint

@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Jan 24, 2025
@yec-akamai yec-akamai requested a review from a team as a code owner January 24, 2025 20:40
@yec-akamai yec-akamai requested review from zliang-akamai and ezilber-akamai and removed request for a team January 24, 2025 20:40
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests passing locally.

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well, nice work!

@yec-akamai yec-akamai merged commit 9e7b52c into linode:dev Jan 30, 2025
12 checks passed
@yec-akamai yec-akamai deleted the TPT-3315/delete-vlan branch January 30, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants