-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tech-story: [M3-9098] - Add MSW crud support for firewalls and some IP functionality for Linode Interfaces project #11586
Open
coliu-akamai
wants to merge
12
commits into
linode:develop
Choose a base branch
from
coliu-akamai:m3-9098
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+642
β14
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
078ec2d
begin adding mock crud operations
coliu-akamai cccfbf9
add seeder
coliu-akamai 3d29aa2
update firewall types as per api spec clarifications
coliu-akamai 9958b37
add more handlers
coliu-akamai 0ce419e
add more handlers
coliu-akamai a236413
changeset
coliu-akamai 8da6693
fix updating, add updating rules
coliu-akamai a975a96
fix bugs for adding/deleting devices
coliu-akamai 8751272
add todo comments
coliu-akamai 7c3589b
not seeding firewall devices
coliu-akamai 903c617
add some more handlers
coliu-akamai 839912b
fix incorrect label for ip address seed @hkhalil-akamai
coliu-akamai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/manager/.changeset/pr-11586-tech-stories-1738337978024.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@linode/manager": Tech Stories | ||
--- | ||
|
||
Add MSW crud operations for firewalls and get operations for IP addresses ([#11586](https://github.com/linode/manager/pull/11586)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { | ||
createFirewall, | ||
createFirewallDevice, | ||
deleteFirewall, | ||
deleteFirewallDevice, | ||
getFirewallSettings, | ||
getFirewallTemplates, | ||
getFirewalls, | ||
updateFirewall, | ||
updateFirewallRules, | ||
updateFirewallSettings, | ||
} from 'src/mocks/presets/crud/handlers/firewalls'; | ||
|
||
import type { MockPresetCrud } from 'src/mocks/types'; | ||
|
||
export const firewallCrudPreset: MockPresetCrud = { | ||
group: { id: 'Firewalls' }, | ||
handlers: [ | ||
createFirewall, | ||
createFirewallDevice, | ||
deleteFirewall, | ||
deleteFirewallDevice, | ||
getFirewalls, | ||
getFirewallSettings, | ||
getFirewallTemplates, | ||
updateFirewall, | ||
updateFirewallRules, | ||
updateFirewallSettings, | ||
], | ||
id: 'firewalls:crud', | ||
label: 'Firewall CRUD', | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating this - it'd been a typo in the spec, see [M3-9210] for details