Release v1.136.0 - release → staging #11623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/instances` (#11527) * starting to create types and endpoints * more types/endpoints - see if consolidation possible * type update * update types * begin adding schemas * taking note of extra null values for modify payload vs create * update types - will have both modify and create (and also get) * added validation schemas * changesets * double check things * update type * add clarifying comment * use beta api root instead * feedback pt1 * types changes didn't get committed * update some requires for validation schema (still need to figure out allowing only one interface) * infer types based on schemas instead @bnussman-akamai * add events to fix test failure
…11474) * rechecking everything - step 1 * steps 2-4 * step 5 (after this gets a bit finnicky i think) * step 6 initial changes - 23f, 29p * steps 6-7 ish * switch PG create back to react router dom (used in LinodeCreate as well) getting closer revert rest of createDrawer router changes maybe a bit closer?? fix landing state prevent query from firing when NaN trying to add routing for search and order by pg linodes table * drawer/modal for pg landing * feeling a lot better about this updated order by pg linodes table * pg linodes table - pagination and dialog data * update failing e2e * more unit tests passing than ever before :) * testing pls send help * test cleanup * some cleanup pt1 + address initial feedback * Added changeset: Refactor routing for Placement Groups to use Tanstack Router * fix e2e delete test * infer search types @bnussman-akamai * fix duplicate import missed during rebase * fix issue with delete modal rendering * remove extra loading after unassigning a linode --------- Co-authored-by: Alban Bailly <[email protected]>
… 1 (#11528) * Add Labels and Taints drawer to node pool options * Add Label table * Add Taint types and table * Save WIP: Add labels and taints * Add ability to remove label from table * Add ability to remove taint from table * Add missing L&T option to collapsed activity menu; clean up * Add most test coverage for drawer view and delete * Add submit functionality to drawer for updates * Feature flag button/menu item until Part 2 is ready * Finish test coverage * Add changesets * Update packages/manager/src/features/Kubernetes/KubernetesClusterDetail/NodePoolsDisplay/LabelsAndTaints/LabelAndTaintDrawer.tsx Co-authored-by: Hana Xu <[email protected]> * Address feedback: actually use the mockType in the mocked request * Address UX feedback: use outlined Add buttons * Address feedback: fix 'X' alignment; improve spacing * Fix bug where primary CTA was enabled when it shouldn't be * Fix factory default for labels and update test * Clean up in test * Address feedback: store labels array in const * Fix bug with labelsArray * Added changeset: Labels and Taints types and params --------- Co-authored-by: Hana Xu <[email protected]>
* initial updates * add changesets --------- Co-authored-by: Banks Nussman <[email protected]>
…texts and minor changes (#11543) * change: [DI-22875] - Changed the validation error messages, tool-tip texts for create-alert and changed naming in constants.ts for consistency * Added changeset: the validation error messages and tooltip texts for create-alert-form, relevant Unit Tests, variables in `constants.ts ` for consistency * Added changeset: validation error messages for the CreateAlertDefinition schema * upcoming: [DI-22875] - Review changes: Changeset changes
…ames for Unavailable Regions (#11530) * initial commit. not working yet * [MS-9030] add mock endpoint * [MS-9030] add assertions to new tests * Added changeset: Warning notice for unavailable region buckets * MS-9030 edits after comments on pr
…urces section in CloudPulse alerts show details page (#11541) * upcoming: [DI-22132] - Initial changes for adding resources section * upcoming: [DI-22838] - Added unit tests * upcoming: [DI-22838] - Error message corrections * upcoming: [DI-22838] - Add a skeletal table * upcoming: [DI-22838] - Update comments * upcoming: [DI-22838] - Add UT for utils * upcoming: [DI-22838] - Sorting, filtering and pagination support * upcoming: [DI-22838] - Add UT for utils functions * upcoming: [DI-22838] - Lint formatting fixes * upcoming: [DI-22838] - Added changeset * upcoming: [DI-22838] - UT fixes * upcoming: [DI-23081] - Code review and changes * upcoming: [DI-23081] - Code refactoring and UT updates * upcoming: [DI-23081] - Code refactoring and UT updates * upcoming: [DI-23081] - Code refactoring * upcoming: [DI-23081] - Code refactoring * upcoming: [DI-23081] - Added comments * upcoming: [DI-23081] - Code optimisations * upcoming: [DI-23081] - Code optimisations * upcoming: [DI-23081] - keys update * upcoming: [DI-23081] -Scroll fix * upcoming: [DI-23081] -Scroll fix * upcoming: [DI-23081] - Remove unused variable * upcoming: [DI-23081] - Label validations and code updates * upcoming: [DI-23081] - Reusable function * upcoming: [DI-23081] - Code comments * upcoming: [DI-23081] - Test error fixes * upcoming: [DI-23081] - Mock for scroll * upcoming: [DI-23081] - Code refactoring * upcoming: [DI-23081] - Code refactoring * upcoming: [DI-23081] - Code refactoring --------- Co-authored-by: vmangalr <[email protected]>
….ts` failure, address `DatabaseBackups.test.tsx` flake (#11561) * don't use the old headless anymore * fix linode resize test due to api error response change * chanegsets * I can't take it any longer * I'm going to rage --------- Co-authored-by: Banks Nussman <[email protected]>
* API spec update * Create feature-flagged placeholder Account Quotas tab * Add DocumentTitleSegment * Added changeset: Add placeholder Quotas tab in Accounts page * Added changeset: Quotas API spec to make region field optional * PR feedback @abailly-akamai @mjac0bs
…dpoints and types for Linode Interfaces (#11562) * begin updating account endpoints * update vpc endpoints and types * changesets * update vpc ip endpoint * add service-transfer endpoints * update import * update file name * address feedback @bnussman-akamai
…11534) * add `udp_check_port` support * improve the ui shifting * add changesets * fix unit test * fix prettier * fix cypress test now that Cookie option was removed * fix typecheck * remove test skip * make payload satisfy api change --------- Co-authored-by: Banks Nussman <[email protected]>
…abled (#11565) * API spec update * Create feature-flagged placeholder Account Quotas tab * Add DocumentTitleSegment * Added changeset: Add placeholder Quotas tab in Accounts page * Added changeset: Quotas API spec to make region field optional * PR feedback @abailly-akamai @mjac0bs * Fix Quotas link appearing in UserMenu when feature flag is off
…ing (#11550) ## Description 📝 Follow-up to #10639 (review) ## Changes 🔄 - Add a small loading state when the user is switching between different region filters - Removed temporary `placeholderData: keepPreviousData` loading fix in `useAllLinodesQuery` - Removed e2e workaround #11107 as a result of ^ ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure you have gecko customer tags (check project tracker) - Create a Linode in a distributed region ### Reproduction steps (How to reproduce the issue, if applicable) - [ ] Checkout a different branch and filter by Core/Distributed region on the Linodes Landing page. - [ ] Notice a slight delay and no loading indication while filtered Linodes are fetched ### Verification steps (How to verify changes) - [ ] Checkout this branch or PR preview link - [ ] Filter by Core/Distributed region on the Linodes Landing page - [ ] Linodes in a list view (with or w/o tags) have a table loading state - [ ] Linodes in a summary view (with or w/o tags) have a circle spinner loading state ``` yarn cy:run -s "cypress/e2e/core/placementGroups/delete-placement-groups.spec.ts" ```
…pages (#11532) * work * progress * more parity * more progress * more fixes and improvments * more fixes and improvments * finish form setup * changeset * fix up unit tests * dial in error handling * enforce that there is atleast one image in create schema * add `DocumentTitleSegment`s * assert toast in stackscript create cypress test * make `rev_note` human readable * remove new learn more link in tooltip * add changeset for user facing changes * feedback @harsh-akamai --------- Co-authored-by: Banks Nussman <[email protected]>
…inode's details page (#11568) * Surface LKE cluster id on Linode details; link to cluster * Move linked LKE cluster to its own section; make spacing consistent * Added changeset: LKE cluster label and id on associated Linode's details page * Add unit test coverage * Update packages/manager/src/features/Linodes/LinodeEntityDetailBody.tsx Co-authored-by: Purvesh Makode <[email protected]> --------- Co-authored-by: Purvesh Makode <[email protected]>
…ypes for Linode Interfaces (#11559) * update firewall template endpoints * existing /networking endpoints and fix resulting type errors * add changesets, fix some types * update types * Update packages/manager/src/factories/firewalls.ts Co-authored-by: Banks Nussman <[email protected]> * add comment for follow up, remove unneeded constant * new type for FirewallTemplate rules + todo comment * update fields/types for Firewall Rules - double check query updates... * update versioning in updateFirewallRules query cache * bruh (at myself!!!) * update comments --------- Co-authored-by: Banks Nussman <[email protected]>
…#11567) * inital feature * use `ActionsPanel` * remove unused import * add cypress test for linode firewalls * add similar test for NodeBalancers * add changesets * use `one` insted of `1` @coliu-akamai * address mobile layout feedback and finalize copy * update unit tests --------- Co-authored-by: Banks Nussman <[email protected]>
…lity - Part 1 (#11512) * refactor: [M3-8253] - Replace pathOr ramda function with custom utility * pathOr file change * Added changeset: Replace ramda's `pathOr` with custom utility * unit test fix * replaced pathOr with optional chaining wheverever possible * added unit tests for pathOr utility * replaced pathOr with native implementation
* Initial commit * Convert DomainRecordDrawer to func component * Move defaultFieldsState to utils * Some fixes and add todo note * An attempt to use react-hook-form * Integrated react-hook-form for remaining forms and fields * Clean up backups * More cleanup and refactoring... * Proper placement * Some improvements and fixes * clean up... * Handle other errors * Some cleanup and refactoring * Added changeset: Refactor `DomainRecordDrawer` to a functional component and use `react-hook-form` * Some clean up.. * More clean up * Improvements and fixes... * Fix root error condition * Handle multiple root errors at a time * Resolve merge conflicts * feedback @abailly-akamai * Minor type fix - remove unnecessary export
…fy the Alerts Show Details page (#11525) * DI-22827:E2E Automation Cypress for Alerting: Show Details and Navigation Verifications * DI-22827:E2E Automation Cypress for Alerting: Show Details Page code review comments * DI-22827:E2E Automation Cypress for Alerting: Show Details Page code review comments * upcoming: [DI-22132] - Add qa ids for alert-show-details overview section * upcoming: [DI-22132] - Add qa ids for alert-show-details overview section * DI-22827: Automate Alerts Show Details page functionality * upcoming: [DI-22838] - QA ids for criteria component * upcoming: [DI-22838] - QA ids for criteria component * upcoming: [DI-22838] - QA ids for criteria component * DI-22827: Automate Alerts Show Details page functionality * add change set * DI-22827: Refactor and improve the DBaaS Alert Show Details page spec file * DI-2282:7Refactor and improve the DBaaS Alert Show Details page spec file * DI-22827:Refactor and improve the Alert Show Details page spec file * DI-22827:Remove unused variables from the spec * DI-22827:Remove the string literal * DI-22827:Addressing code review comments * DI-20931:fixing the issue in spec file * DI-22827: Refactor test to optimize navigation, improve efficiency, and address code review feedback * DI-22827: Refactor test to optimize navigation, improve efficiency, and address code review feedback --------- Co-authored-by: vmangalr <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]>
…1564) * Add functions to getCookie and getOptanonConsentCategory * Clean up and document functions * Add unit test coverage for utils; clean up * Fix cookie type - performance, not functional * Clean up variable names in test * Make utils more efficient, better naming * Skip the cookie check when running localhost * Update dev docs * Added changeset: Enable Pendo based on OneTrust cookie consent * Address feedback: cleaner assignments * Oops forgot to switch the conditional
Release v1.135.0 - staging → master
…ls component to Create-alert-form (#11547) * upcoming: [DI-23103] - added AddChannelListing and RenderChannelDetails components with unit tests along with relevant query requests, minor changes to include the added components * upcoming: [DI-23103] - Added changeset * upcoming: [DI-23103] - Review changes * upcoming: [DI-23103] - Review changes: Added form context to AddChannelListing and localized AddNotificationChannel and the state management to the AddChannelListing component * upcoming: [DI-23103] - Review comments * upcoming: [DI-23103] - Memoized the NotificationChannelCard component * upcoming: [DI-23103] - Renamed the NotificationChannels fetching query for consistency
…oudPulse alert details page (#11554) * upcoming: [DI-22283] - Notification channel code changes * upcoming: [DI-22283] - Changeset * upcoming: [DI-22283] - Code refactoring * upcoming: [DI-22283] - Code refactoring * upcoming: [DI-22283] - Code refactoring * upcoming: [DI-22283] - Code refactoring * upcoming: [DI-22283] - As per upstream * upcoming: [DI-22283] - As per upstream * upcoming: [DI-22283] - Code refactoring * upcoming: [DI-22283] - UT optimisation * upcoming: [DI-22283] - Edit changeset * upcoming: [DI-22283] - server handler changes * upcoming: [DI-22283] - Common function * upcoming: [DI-22283] - Comments * upcoming: [DI-22283] - Comments * upcoming: [DI-22283] - Comment updates * upcoming: [DI-22283] - Changeset update * upcoming: [DI-22283] - nit pick comment fixes * upcoming: [DI-22283] - As per dev * as per upstream * upcoming: [DI-22283] - API V4 changeset not needed * upcoming: [DI-22283] - Changeset update --------- Co-authored-by: vmangalr <[email protected]>
…Implicit Flow (#10600) Co-authored-by: Joe D'Amore <[email protected]>
…t storage creation (#11560) * M3-7511 refactoring, add tests for landing page * M3-7511 restore disabled tests * M3-7511 corrections * Added changeset: tests of object storage creation form for restricted user * M3-7511 edits after pr feedback * M3-7511 edits after pr comments * Update packages/manager/.changeset/pr-11560-tests-1737658018185.md Co-authored-by: Mariah Jacobs <[email protected]> --------- Co-authored-by: Mariah Jacobs <[email protected]>
…P functionality for Linode Interfaces project (#11586) * begin adding mock crud operations * add seeder * update firewall types as per api spec clarifications * add more handlers * add more handlers * changeset * fix updating, add updating rules * fix bugs for adding/deleting devices * add todo comments * not seeding firewall devices * add some more handlers * fix incorrect label for ip address seed @hkhalil-akamai * address feedback @abailly-akamai
* initial work on landing page * clean up feature flag * add changesets * add new region capability * Revert "add new region capability" This reverts commit cec3768. * mention that images will be automatically encrypted * new copy * hide unencrypted icon while image is creating --------- Co-authored-by: Banks Nussman <[email protected]>
…11603) * Remove `@types/react-beautiful-dnd` dependency * Added changeset: Remove `@types/react-beautiful-dnd` dependency
* update `markdown-it` to v14 * add changeset * revert accidental change --------- Co-authored-by: Banks Nussman <[email protected]>
## Description 📝 Fix clicking disabled delete button also collapsing/expanding the accordion. No changeset needed as this hasn't been released yet ## Target release date 🗓️ 2/11/15 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Have a LKE or LKE-E cluster set up with 1 node pool ### Verification steps (How to verify changes) - [ ] Go to a LKE or LKE-E cluster with only 1 node pool - [ ] Click on the disabled delete pool button. The accordion should stay as is and not expand or collapse from the click
…s and types for Linode Interfaces project (#11566) * begin initial updating of types * wow this is kinda bad... * add todo comments * fix a lot of type errors... * add comment * maybe this? * update validation schema * add changesets * update comments * update comments * update interface schema again * update types * update schema again * update schema ipv4 field * update schema @bnussman-akamai * feedback pt1 * save work * ok 5 type errors left... * mix of type guarding and updating LinodeCreateFormValues * feels full circle -> properties type guard now * add todo comments * revert change * memoize value @abailly-akamai
* initial refactoring * more progress * a little but of clean up * a little bit more progress * a few fixes * react queryify more * more progress * parity with old ui * properly handle error state * more progress * fix typecheck * get tests passing * add some testing * small fixes * unrelated bug fix * unrelated bug fix * get closer to parity with old code * re-add span to fix cypress tests * use correct `Typography` import * fix up e2e tests * fix type errors * Added changeset: Refactor StackScripts landing page * Apply suggestions from code review Co-authored-by: Mariah Jacobs <[email protected]> * improve restricted user support * sort imports * update cypress test after removing crazy copy --------- Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]>
hkhalil-akamai
requested review from
dmcintyr-akamai,
dwiley-akamai and
pmakode-akamai
and removed request for
a team
coliu-akamai
reviewed
Feb 6, 2025
There were no changesets in UI although looks like there were some minor changes. I'm guessing it's fine to omit the version bump/changelog unless anyone disagrees? |
coliu-akamai
previously approved these changes
Feb 6, 2025
abailly-akamai
approved these changes
Feb 6, 2025
coliu-akamai
approved these changes
Feb 6, 2025
dwiley-akamai
approved these changes
Feb 6, 2025
hana-akamai
approved these changes
Feb 6, 2025
|
Coverage Report: ❌ |
Cloud Manager UI test results🎉 500 passing tests on test run #2 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
staging
|
| Run status |
|
| Run duration | 33m 09s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
499
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
cypress/e2e/core/linodes/linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Changed:
RegionMultiSelectin the "Manage Image Regions" drawer ignore account capabilities (#11598)Fixed:
Tech Stories:
pathOrwith custom utility (#11512)imageServiceGen2andimageServiceGen2Gafeature flags (#11579)DomainRecordspt2 (#11587)disallowImageUploadToNonObjRegionsfeature flag (#11598)ignoreAccountAvailabilityprop toRegionMultiSelect(#11598)markdown-itto v14 (#11602)@types/react-beautiful-dnddependency (#11603)DomainRecordDrawerto a functional component and usereact-hook-form(#11538)Tests:
--headless=oldChrome flag to run headless Cypress tests (#11561)resize-linode.spec.tstest failure caused by updated API notification message (#11561)Upcoming Features:
interface_create,interface_delete, andinterface_updateevents (#11527)/v4/networkingendpoints (#11559)