-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7112] - Add invoice generation tests for PdfGenerator.ts #11625
Open
pmakode-akamai
wants to merge
23
commits into
linode:develop
Choose a base branch
from
pmakode-akamai:M3-7112-add-invoice-generation-tests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: [M3-7112] - Add invoice generation tests for PdfGenerator.ts #11625
pmakode-akamai
wants to merge
23
commits into
linode:develop
from
pmakode-akamai:M3-7112-add-invoice-generation-tests
+514
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
commented
Feb 6, 2025
const remitAddress = isAkamaiBilling | ||
? ['CA', 'US'].includes(country) | ||
? ADDRESSES.akamai.us | ||
: ADDRESSES.akamai.international | ||
: ADDRESSES.linode; | ||
const remitAddress = getRemitAddress(country, isAkamaiBilling); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0ca6e41
to
d2fdf3d
Compare
Coverage Report: ✅ |
Cloud Manager UI test results🎉 500 passing tests on test run #10 ↗︎
|
carrillo-erik
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add'tl Approval Needed
Waiting on another approval!
Dependencies
Pull requests that update a dependency file
Unit tests
Improves unit test coverage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
pdfreader
dependency to parse the pdf files 📦 🧾getRemitAddress
util 🧪getRemitAddress
to utils and reuse this utility in unit tests andPdfGenerator.ts
♼Target release date 🗓️
N/A
How to test 🧪
yarn test PdfGenerator --reporter verbose
getRemitAddress
utility is working correctly in the PDF footerAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅