Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-6675] - Remove span from button component #11627

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hasyed-akamai
Copy link
Contributor

@hasyed-akamai hasyed-akamai commented Feb 6, 2025

Description 📝

This PR removes the <span> component from the children of the Button component. This change will make it easier for test selectors to locate button elements without having to first find the <span> and then locate the closest button.

Changes 🔄

  • Remove <span> from Button component children to simplify test selector targeting.

Target release date 🗓️

N/A

Verification steps

  • Verify that button elements can now be found directly by test selectors without needing to reference the <span>.
  • Ensure no existing functionality is broken and no regressions are introduced.
  • Confirm all tests pass successfully.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@hasyed-akamai hasyed-akamai self-assigned this Feb 6, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 500 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing500 Passing2 Skipped112m 46s

@hasyed-akamai hasyed-akamai marked this pull request as ready for review February 10, 2025 05:59
@hasyed-akamai hasyed-akamai requested review from a team as code owners February 10, 2025 05:59
@hasyed-akamai hasyed-akamai requested review from dmcintyr-akamai, hkhalil-akamai and harsh-akamai and removed request for a team February 10, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants