Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-8446] - restore backup date and time fix #11628

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Feb 6, 2025

Description 📝

Fix for Timezone Display Inconsistency During Restore Backup

Changes 🔄

  • Updated the date-time picker to consistently show times in UTC
  • Prevented restoring from a timestamp in the future
  • Ensured the time selected for restoration will always be in UTC

Target release date 🗓️

2/11/25

Preview 📷

Before After
Screenshot 2025-02-06 at 5 01 24 PM Screenshot 2025-02-06 at 5 01 05 PM
Screenshot 2025-02-06 at 5 02 08 PM Screenshot 2025-02-06 at 5 02 19 PM

How to test 🧪

Verification steps

Newest full backup:

  • Navigate to the Backups tab in your database cluster
  • Select “Restore a Backup” using the “Newest full backup plus incremental” option
  • Check that the time displayed in the modal shows UTC time
  • After selecting "Restore," a new database will be created with a UTC timestamp appended

Specific Date & Time:

  • Navigate to the Backups tab in your database cluster
  • Select “Restore a Backup” using the “Specific date & time” option
  • Choose today’s date
  • Verify the dropdown displays UTC hourly times to select, with future times after the current UTC time being disabled
  • The selected time will restore in UTC as chosen
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner February 6, 2025 16:13
@mpolotsk-akamai mpolotsk-akamai requested review from dwiley-akamai and coliu-akamai and removed request for a team February 6, 2025 16:13
@mpolotsk-akamai mpolotsk-akamai force-pushed the feature/UIE-8446-restore-backup-time branch 2 times, most recently from 017afaa to ec3014e Compare February 6, 2025 16:26
Copy link

github-actions bot commented Feb 6, 2025

Coverage Report:
Base Coverage: 78.94%
Current Coverage: 78.94%

@cpathipa cpathipa requested review from cpathipa and removed request for coliu-akamai February 7, 2025 14:52
@cpathipa cpathipa added the DBaaS Relates to Database as a Service label Feb 7, 2025
cpathipa
cpathipa previously approved these changes Feb 7, 2025
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirming on the verifications steps.
image

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Feb 7, 2025
@mpolotsk-akamai mpolotsk-akamai force-pushed the feature/UIE-8446-restore-backup-time branch from ec3014e to 75bf6f0 Compare February 7, 2025 15:22
@mpolotsk-akamai mpolotsk-akamai changed the base branch from develop to staging February 7, 2025 15:23
@mpolotsk-akamai mpolotsk-akamai dismissed cpathipa’s stale review February 7, 2025 15:23

The base branch was changed.

@jaalah-akamai jaalah-akamai added the Bug Fixes for regressions or bugs label Feb 7, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing491 Passing7 Skipped141m 4s

Details

Failing Tests
SpecTest
third-party-access-tokens.spec.tsThird party access tokens » "before each" hook for "Revokes a third party access token"
service-transfer.spec.tsAccount service transfers » "before all" hook for "can navigate to service transfers landing page"
user-profile.spec.tsUser Profile » can change the username but not email of another user account
user-profile.spec.tsUser Profile » cannot change username or email for a proxy user or delete the proxy user

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/account/third-party-access-tokens.spec.ts,cypress/e2e/core/account/service-transfer.spec.ts,cypress/e2e/core/account/user-profile.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality ✅
Code review ✅
utilities.test.tsx passing locally & in CI ✅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR is being pointed at staging, the changelog should be updated directly instead of having a changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants