Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix healthcheck and streaming with whisper #59

Merged
merged 25 commits into from
Jan 31, 2025
Merged

Fix healthcheck and streaming with whisper #59

merged 25 commits into from
Jan 31, 2025

Conversation

AudranBert
Copy link
Member

@AudranBert AudranBert commented Jan 7, 2025 •
edited
Loading

This PR aims at fixing #49 #47 and #58 by:

  • Fix the healthcheck for the websocket mode
  • Fix healthcheck for the http mode (by adding curl to the docker images)
  • Fix partial and final for streaming with Whisper
  • Asynchronous transcription for streaming (not blocking packet reception)
  • Remove http+ENABLE_STREAMING for Whisper. It will redirect to websocket mode
  • Update the doc
  • Update the tests

What remains to be done:

  • More testing
  • Improve asynchronous transcription
  • Improve doc

@AudranBert
update test_streaming for new partail/final method
4341d9e 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
Fix first part of #49 (no timeouts)
f66a3ac 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
asynchronus test streaming
c153a34 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
asynchronous prediction + fix final and partial
1af95a2 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
redirect http+streaming to websocket mode
84edaf7 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
fix #47 (healthcheck for websocket mode)
6813545 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
fix #58 : add curl in docker
754974d 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
update whisper readme
5e44b2c 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
update readme + add new variables for streaming
d04c13a 
Signed-off-by: AudranBert <[email protected]>
@AudranBert AudranBert requested a review from Jeronymous January 7, 2025 15:58
@AudranBert AudranBert self-assigned this Jan 7, 2025
This was linked to issues Jan 8, 2025
Healthcheck broken for streaming #47
Open
Whisper streaming - Buffer audio & incorrect finals #49
Open
Healthcheck broken for http service mode #58
Open
Jeronymous
Jeronymous reviewed Jan 8, 2025
View reviewed changes
healthcheck.sh Outdated Show resolved Hide resolved
@damienlaine damienlaine self-requested a review January 8, 2025 16:04
damienlaine
damienlaine requested changes Jan 8, 2025
View reviewed changes
healthcheck.sh Outdated Show resolved Hide resolved
test/test_streaming.py Show resolved Hide resolved
test/test_streaming.py Show resolved Hide resolved
websocket/healthcheck.py Outdated Show resolved Hide resolved
@AudranBert AudranBert requested a review from Jeronymous January 14, 2025 15:28
@AudranBert
fix language error message + small changes
ea7dd8d 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
fix kaldi streaming
4ae62d4 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
fix and update tests
46a03b2 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
fix vad
5990f00 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
remove useless lines
3896f14 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
improve doc + change default value
02c204a 
Signed-off-by: AudranBert <[email protected]>
@AudranBert
add recommendation
e78e864 
Signed-off-by: AudranBert <[email protected]>
@AudranBert AudranBert merged commit 16e8f9d into next Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienlaine damienlaine damienlaine approved these changes

@Jeronymous Jeronymous Awaiting requested review from Jeronymous

Assignees

@AudranBert AudranBert

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@AudranBert @damienlaine @Jeronymous