Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve use of lsp hooks in user configuration options #186

Open
wants to merge 3 commits into
base: regexp
Choose a base branch
from

Conversation

ayooh
Copy link

@ayooh ayooh commented Dec 2, 2024

  • Improve hooks config.
    Users can simply configure the lsp hooks to be used with the Lua table. Example lazy.nvim plugin spec:
    {
      "linux-cultist/venv-selector.nvim",
      opts = {
        settings = {
          lsp_hooks = { pylsp = false },
        },
      },
    },
  • Improve LspAttach event handler.
    Ruff or other lsp servers attached to the buffer will not be handled, so the value of current_pyhon_path will not be messed up. Multiple lsp notify can be prevented by the value of current_python_path and the value in venv cache file.
  • Remove a duplicate unused function.
    The function merge_user_settings is also in utils.lua but is not used.

@linux-cultist
Copy link
Owner

Thank you and sorry for super late response. Will try to have a look at the code this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants