Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings management #190

Open
wants to merge 3 commits into
base: regexp
Choose a base branch
from

Conversation

noirbizarre
Copy link

Hello 👋🏼

First, thanks for this plugin!

I allowed myself to submit this PR adding multiple improvements to the settings handling:

  • remove the unnecessary settings level (in a backward-compatible way)
  • add a Neovim health check for it
  • simplify the associated documentation (same indent, format... for all example, add syntax highlighting)
  • follow lazy.vim recommendations in examples (opts over config)
  • add some LuaCATS annotations, so users can benefit from completion and documentation from Lua LSP

Here's the health check for settings:
image

You can see the rendered README here

@linux-cultist
Copy link
Owner

Looks like some very good work. :) Will try to find time to go though it this week. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants