mlx5: specify unsupport config mkey write relax ordering #1542
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API mlx5dv_wr_set_mkey_access_flags access_flags parameter doesn't support IBV_ACCESS_RELAXED_ORDERING. Signed-off-by: Liu, Changcheng <[email protected]>
yishaih
requested changes
Jan 19, 2025
| @@ -161,7 +161,7 @@ struct mlx5dv_mkey_conf_attr { | |||
|
|
|||
| : The desired memory protection attributes; it is either 0 or | |||
| the bitwise OR of one or more of flags in **enum | |||
| ibv_access_flags**. | |||
| ibv_access_flags**. IBV_ACCESS_RELAXED_ORDERING is not supported. | |||
There was a problem hiding this comment.
This is not the only access flag which is not supported by that DV API (e.g. IBV_ACCESS_ON_DEMAND, IBV_ACCESS_MW_BIND, IBV_ACCESS_ZERO_BASED, etc.).
I would skip/drop this patch, the man page doesn't guarantee that all bits are supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API mlx5dv_wr_set_mkey_access_flags access_flags parameter doesn't support IBV_ACCESS_RELAXED_ORDERING.
https://github.com/linux-rdma/rdma-core/blob/v55.0/providers/mlx5/qp.c#L2951-L2958