Fix utk_test #424
Merged
Fix utk_test #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utk_test was calling sed and diff in non-portable ways; it did not work any more, and it would never work on osx. Remove calls to diff and sed, and just do the equivalent using Go packages. Go test now works on osx. Signed-off-by: Ronald G. Minnich <[email protected]>
orangecms
approved these changes
Sep 16, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
=======================================
Coverage 41.63% 41.63%
=======================================
Files 142 142
Lines 10729 10729
=======================================
Hits 4467 4467
Misses 5394 5394
Partials 868 868 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utk_test was calling sed and diff in non-portable ways; it did not work any more, and it would never work on osx.
Remove calls to diff and sed, and just do the equivalent using Go packages.
Go test now works on osx.