remove golangci-lint #428
Closed
remove golangci-lint #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has useful recommendations, but the output is not great, errors with no indications as to which file it found the error; and it ignores the go version specified in go.mod. Signed-off-by: Ronald G. Minnich <[email protected]>
|
We'll also need to remove the integration in the GitHub project settings. |
|
Let's check also how it behaves locally and if newer versions of tje GitHub integration are available. It may just be a simpler matter of a version bump. |
|
sounds good, whatever seems best. I'm just getting tired of its not quite helpful recommendations. :-) |
|
See #429 - looking good! The Go version to use is not read from go.mod intentionally. The docs https://github.com/golangci/golangci-lint-action tell how to specify both the linter version and the Go version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has useful recommendations, but the output is
not great, errors with no indications as to which
file it found the error; and it ignores the go version specified in go.mod.