Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/bytes: relect.SliceHeader -> unsafe.Slice #430

Closed
wants to merge 1 commit into from

Conversation

rminnich
Copy link
Contributor

No description provided.

Copy link
Collaborator

@orangecms orangecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the second closing paren )

@rminnich rminnich force-pushed the removereflect.SliceHeader branch from be569f0 to b031f6f Compare September 16, 2024 23:36
@rminnich rminnich force-pushed the removereflect.SliceHeader branch from b031f6f to fb4ec78 Compare September 16, 2024 23:37
@rminnich
Copy link
Contributor Author

yeah the go test missed that b/c I'm on an m2 mac, habits are dangerous.

@rminnich
Copy link
Contributor Author

I don't know what golangci-lint was trying to tell me about how to do this, I will have to go RTFM for now.

@rminnich rminnich closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants