feat: improve image dimension detection in property dialog #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnson-zs
approved these changes
Feb 7, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs, Lighto-Ku The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Add QImageReader as fallback method when properties don't contain width/height - Optimize condition checks in imageExtenInfo function - Add QImageReader header inclusion - Add comments to explain the fallback logic This change enhances the reliability of image dimension detection, especially for image formats that don't provide dimension information in their properties. Log: improve image dimension detection in property dialog Bug: https://pms.uniontech.com/bug-view-300075.html
Johnson-zs
force-pushed
the
fix-master
branch
from
357d792 to
c31e743
Compare
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enhances the reliability of image dimension detection, especially for image formats that don't provide dimension information in their properties.
Log: improve image dimension detection in property dialog
Bug: https://pms.uniontech.com/bug-view-300075.html