Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dde-blackscreen #384

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

zsien
Copy link
Contributor

@zsien zsien commented Dec 2, 2024

恢复丢失的 org.deepin.dde.BlackScreen 接口

Bug: https://pms.uniontech.com/bug-view-288277.html

@zsien zsien requested a review from a team December 2, 2024 12:53
@zsien zsien force-pushed the zs/chore/blackscreen branch 3 times, most recently from 8631b53 to 2cbacfd Compare December 2, 2024 13:15
恢复丢失的 org.deepin.dde.BlackScreen1 接口

Bug: https://pms.uniontech.com/bug-view-288277.html
@zsien zsien force-pushed the zs/chore/blackscreen branch from 2cbacfd to f722efb Compare December 2, 2024 13:24
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CMakeLists.txt中,pkg_check_modulespkg_search_module的使用可能需要确认是否正确,因为它们分别用于查找已安装的包和搜索包。如果libsystemd是通过pkg_search_module找到的,那么pkg_check_modules可能是不必要的。
  • dde-blackwidget/src/main.cpp中,QTimer::singleShot的使用可能需要优化,特别是在handleSIGTERM函数中,连续使用QTimer::singleShot可能会导致不必要的定时器堆积。
  • dde-blackwidget/src/window.cpp中,setupSize函数中使用了qInfo来打印调试信息,这可能不是最佳实践,特别是在生产环境中,应该避免使用qInfoqDebug来记录大量日志。
  • dde-blackwidget/src/window.cpp中,releaseGrabDevicesreleaseGrabDevicesHideBlack函数中重复了相同的代码,应该提取公共逻辑到单独的函数中。
  • dde-blackwidget/src/window.h中,const int quitInterval的定义应该放在类的私有部分,而不是公共部分,以避免外部代码直接访问和修改它。
  • dde-blackwidget/src/window.h中,BlackWidgetAdaptor类中的Q_CLASSINFO宏应该使用正确的命名空间,以确保在所有平台上都能正确解析。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zsien zsien merged commit 8ab24bf into linuxdeepin:master Dec 3, 2024
13 of 14 checks passed
@zsien zsien deleted the zs/chore/blackscreen branch December 3, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants