Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: floating message cannot be closed #315

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

rb-union
Copy link
Contributor

@rb-union rb-union commented Jan 2, 2025

See linuxdeepin/dtkwidget#628 The DFloatingMessage not trigger close() now,
wait for DtkWidget integration.

Log: Toast cannot be closed.
Bug: https://pms.uniontech.com/bug-view-297669.html

See linuxdeepin/dtkwidget#628
The DFloatingMessage not trigger close() now,
wait for DtkWidget integration.

Log: Toast cannot be closed.
Bug: https://pms.uniontech.com/bug-view-297669.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的lambda表达式中,this指针的使用可能会导致潜在的内存管理问题,特别是在多线程环境下。
  • 注释中的TODO标记应该被解决,而不是仅仅留下,以确保代码的完整性和可维护性。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit ea732b2 into linuxdeepin:master Jan 2, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants