Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkcore #68

Merged
merged 1 commit into from
Sep 9, 2024
Merged

sync: from linuxdeepin/dtkcore #68

merged 1 commit into from
Sep 9, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#435

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#435
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • ddbusinterface.cpp文件中,使用baSignal.data()baSignalName.data()作为const char *可能会导致不必要的类型转换,应该直接使用baSignalbaSignalName
  • ddbusinterface.cpp中的updateProp函数在调用invokeMethod时使用了QGenericArgument,但在修改后使用了method.parameterTypes().first()method.invoke(m_parent, Qt::DirectConnection, QGenericArgument(method.parameterTypes().first(), data));,这可能会导致类型不匹配的问题,需要确认method.parameterTypes().first()的类型是否与QGenericArgument(method.parameterTypes().first(), data)匹配。
  • ddbusinterface.cpp中的qDebug输出的格式应该保持一致,例如使用<<操作符进行连接,而不是直接拼接字符串。

是否建议立即修改:

@kegechen kegechen merged commit 0efd5df into master Sep 9, 2024
8 of 9 checks passed
@kegechen kegechen deleted the sync-pr-435-nosync branch September 9, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants