Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkcore #86

Merged
merged 1 commit into from
Dec 12, 2024
Merged

sync: from linuxdeepin/dtkcore #86

merged 1 commit into from
Dec 12, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#451

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#451
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • dconfigfile.cpp中,对于filterConvertType的使用可能不正确,因为QMetaType::DoubleQVariant::Double是不同的类型,应该分别处理。
  • dsgapplication.cpp中,关闭pidfd的代码被移动到了QDBusReply之后,这可能会导致在QDBusReply无效时pidfd没有被关闭。
  • dsgapplication.cpp中,qCWarning日志应该包含更多的上下文信息,比如函数名或操作描述。
  • dconf-example.meta.json中新增的numberDouble配置项的value类型为1.0,但是注释中提到MetaType在1.0版本中是qlonglong,这可能会导致类型不匹配的问题。
  • ut_dconfigfile.cpp的测试用例中,对于numberDouble的测试用例没有检查类型转换是否正确。

是否建议立即修改:

@mhduiy mhduiy merged commit 12dc3da into master Dec 12, 2024
11 of 13 checks passed
@mhduiy mhduiy deleted the sync-pr-451-nosync branch December 12, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants