Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #101

Merged
merged 1 commit into from
Dec 9, 2024
Merged

sync: from linuxdeepin/dtkwidget #101

merged 1 commit into from
Dec 9, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-624-nosync branch 5 times, most recently from 96c1282 to c854503 Compare December 9, 2024 05:09
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • dplatformwindowhandle.cpp文件中新增的全局变量g_surfaceType应该被声明为static,以避免潜在的命名空间污染。
  • setWindowSurfaceType函数中的g_surfaceType赋值操作没有进行任何错误检查,可能会导致非法的QWindow::SurfaceType值被设置。
  • setWindowSurfaceType函数的参数类型为int,应该明确注释说明该参数的有效值范围,以避免使用非法值。

是否建议立即修改:

@kegechen kegechen merged commit 4455a1a into master Dec 9, 2024
12 of 14 checks passed
@kegechen kegechen deleted the sync-pr-624-nosync branch December 9, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants