Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #45

Merged
merged 1 commit into from
May 13, 2024
Merged

sync: from linuxdeepin/dtkwidget #45

merged 1 commit into from
May 13, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-566-nosync branch 4 times, most recently from 333a1be to 90a76bb Compare April 29, 2024 02:26
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 29, 2024

TAG Bot

New tag: 6.0.14
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #47

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 30, 2024

TAG Bot

New tag: 6.0.15
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #48

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DPrintPreviewDialogPrivate::initconnections()DPrintPreviewDialogPrivate::_q_printerChanged()中,_q_customPagesFinished()替换了原来的pageRangeCombo->setCurrentIndex(PAGERANGE_ALL);,需要确认这个替换是否正确并且逻辑上是必要的。
  • DPrintPreviewDialogPrivate::_q_pageMarginChanged()DPrintPreviewDialogPrivate::_q_orientationChanged()中,_q_customPagesFinished()也进行了类似的替换,但同样需要确认逻辑是否正确。

是否建议立即修改:

  • 是,需要确认替换后的逻辑是否与原来的逻辑一致,并且没有引入任何潜在的问题。如果_q_customPagesFinished()的调用改变了原有的功能或者逻辑不正确,那么应该立即修复。

@kegechen kegechen merged commit e8d8171 into master May 13, 2024
9 of 12 checks passed
@kegechen kegechen deleted the sync-pr-566-nosync branch May 13, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants