Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #54

Closed
wants to merge 1 commit into from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#577

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-577-nosync branch 9 times, most recently from 0a5a4ed to 72b580e Compare May 28, 2024 08:30
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#577
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DAbstractDialogPrivate::init函数中,对于窗口阴影处理的逻辑可能不正确,因为它在非标题栏模式下设置了Qt::WA_TranslucentBorder属性,但在标题栏模式下没有。建议统一处理这种属性。
  • handle->enableBlurWindow()的返回值被直接检查,但没有考虑到可能返回的是一个异常或者无效的值,应该对返回值进行有效的检查。
  • DDialogPrivate::init函数中,mainLayoutbuttonLayout的缩进和空格使用不一致,建议统一代码风格。

是否建议立即修改:

@mhduiy mhduiy closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants