Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #55

Merged
merged 1 commit into from
Jul 3, 2024
Merged

sync: from linuxdeepin/dtkwidget #55

merged 1 commit into from
Jul 3, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#578

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#578
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DAbstractDialogPrivate::init函数中,新增代码块没有处理enableBlurWindow可能失败的情况,应该添加错误处理逻辑。
  • mainLayoutbuttonLayoutsetSpacing方法调用可能需要考虑布局的网格设置,以避免潜在的布局问题。
  • DIALOG::BUTTON_LAYOUT_LEFT_MARGINDIALOG::BUTTON_LAYOUT_TOP_MARGINDIALOG::BUTTON_LAYOUT_RIGHT_MARGIN等常量可能需要检查是否已经定义,以避免未声明的变量错误。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 27, 2024

TAG Bot

New tag: 6.0.17
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #59

@mhduiy mhduiy merged commit c45fcc3 into master Jul 3, 2024
7 of 9 checks passed
@mhduiy mhduiy deleted the sync-pr-578-nosync branch July 3, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants