Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #64

Merged
merged 1 commit into from
Aug 20, 2024
Merged

sync: from linuxdeepin/dtkwidget #64

merged 1 commit into from
Aug 20, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#588

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#588
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • dynamic_cast 应该使用 itemAt 方法来获取布局中的项目,而不是 takeAt 方法。
  • delete 操作应该在确认 QSpacerItem 已经被正确移除后再进行。

是否建议立即修改:

@mhduiy mhduiy merged commit 685d8f5 into master Aug 20, 2024
11 of 14 checks passed
@mhduiy mhduiy deleted the sync-pr-588-nosync branch August 20, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants