Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #75

Merged
merged 1 commit into from
Sep 25, 2024
Merged

sync: from linuxdeepin/dtkwidget #75

merged 1 commit into from
Sep 25, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#599

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#599
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DMainWindowPrivate::DMainWindowPrivate函数中,新增的代码块可能会导致titlebar变量未初始化就进行了使用。
  • DTitlebarPrivate::init函数中的noTitlebarEnabledlambda函数使用了未定义的qEnvironmentVariable函数,可能会导致编译错误或运行时错误。
  • DTitlebarPrivate::updateButtonsState函数中的新增条件|| qEnvironmentVariable("DDE_CURRENT_COMPOSITOR") == "TreeLand"可能会影响原有的功能,需要确认这一改动是否符合预期。

是否建议立即修改:

@FeiWang1119 FeiWang1119 merged commit 40a4a63 into master Sep 25, 2024
11 of 14 checks passed
@FeiWang1119 FeiWang1119 deleted the sync-pr-599-nosync branch September 25, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants