Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): build faild on Qt6.7 #420

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

kegechen
Copy link
Contributor

QAbstractFileEngine::FileTime ==> QFile::FileTime

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 24, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#420
@kegechen kegechen requested a review from felixonmars May 24, 2024 01:18
@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 24, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

asterwyx
asterwyx previously approved these changes May 27, 2024
@wineee
Copy link
Member

wineee commented May 27, 2024

nixos 可用

src/dci/private/ddcifileengine.cpp Outdated Show resolved Hide resolved
QAbstractFileEngine::FileTime ==> QFile::FileTime
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在DDciFileEngine类中,根据QT版本的条件编译可能导致函数签名不一致,建议统一函数签名以避免混淆。
  • 使用static_cast进行类型转换时,应确保QAbstractFileEngine::FileTimeQFile::FileTime在所有相关平台上都是兼容的,否则可能会引发运行时错误。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 28, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#420
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, kegechen, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 10bd384 into linuxdeepin:master May 28, 2024
20 of 21 checks passed
kegechen pushed a commit to linuxdeepin/dtk6core that referenced this pull request May 28, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants