Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary link libraries #432

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

rb-union
Copy link
Contributor

These two libraries are used to detect text encoding,
but they are actually loaded dynamiclly.
Not need to link libraries.

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#432
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 5.6.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #433

These two libraries are used to detect text encoding,
but they are actually loaded dynamiclly.
Not need to link libraries.
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Aug 23, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#432
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 移除了对ICU::uc和uchardet库的链接,需要确认这些库是否不再被项目使用。
  • 检查Qt${QT_VERSION_MAJOR}::CorePrivate的替代实现,因为移除了uchardet可能会影响字符识别功能。

是否建议立即修改:

  • 是,需要确保移除的库不会影响项目功能,并且检查替代实现是否正确。

@kegechen kegechen merged commit b0efc5a into linuxdeepin:master Sep 9, 2024
18 of 21 checks passed
kegechen pushed a commit to linuxdeepin/dtk6core that referenced this pull request Sep 9, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants