Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to change window effects #249

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

18202781743
Copy link
Contributor

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Aug 8, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#249
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • EffectSceneEffectType枚举中,移除了不必要的EffectNoRadiusEffectNoShadowEffectNoBorderEffectNoStartEffectNoCloseEffectNoMaximizeEffectNoMinimize,这些枚举值在windowEffectwindowStartUpEffect方法中没有被使用。
  • 添加了对EffectSceneEffectType枚举的Q_ENUM和Q_DECLARE_FLAGS宏,这有助于在Qt中使用这些枚举类型。
  • DPlatformHandle类中添加了windowEffectwindowStartUpEffect方法,用于获取和设置窗口效果和启动效果。
  • DPlatformHandle类的setWindowEffectsetWindowStartUpEffect方法中,使用了static_cast<quint32>进行类型转换,这可能是为了确保枚举值被正确地存储和检索。

是否建议立即修改:

  • 否,当前的修改看起来是对代码的清理和优化,没有发现需要立即修改的关键问题。但是,建议进行进一步的代码审查以确保没有遗漏其他潜在的问题。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 8, 2024

Doc Check bot
🟡 some documents missing!

File Line Symbol
include/kernel/dplatformhandle.h 87 EffectType
include/kernel/dplatformhandle.h 87 EffectNormal
include/kernel/dplatformhandle.h 87 EffectCursor
include/kernel/dplatformhandle.h 87 EffectTop
include/kernel/dplatformhandle.h 87 EffectBottom
include/kernel/dplatformhandle.h 107 bool Dtk::Gui::DPlatformHandle::setWindowBlurAreaByWM
include/kernel/dplatformhandle.h 101 static bool Dtk::Gui::DPlatformHandle::setWindowBlurAreaByWM
include/kernel/dplatformhandle.h 124 QPainterPath Dtk::Gui::DPlatformHandle::clipPath
include/kernel/dplatformhandle.h 125 QRegion Dtk::Gui::DPlatformHandle::frameMask
include/kernel/dplatformhandle.h 126 QMargins Dtk::Gui::DPlatformHandle::frameMargins
include/kernel/dplatformhandle.h 128 bool Dtk::Gui::DPlatformHandle::translucentBackground
include/kernel/dplatformhandle.h 129 bool Dtk::Gui::DPlatformHandle::enableSystemResize
include/kernel/dplatformhandle.h 130 bool Dtk::Gui::DPlatformHandle::enableSystemMove
include/kernel/dplatformhandle.h 131 bool Dtk::Gui::DPlatformHandle::enableBlurWindow
include/kernel/dplatformhandle.h 132 bool Dtk::Gui::DPlatformHandle::autoInputMaskByClipPath
include/kernel/dplatformhandle.h 146 void Dtk::Gui::DPlatformHandle::setShadowOffset
include/kernel/dplatformhandle.h 147 void Dtk::Gui::DPlatformHandle::setShadowColor
include/kernel/dplatformhandle.h 149 void Dtk::Gui::DPlatformHandle::setClipPath
include/kernel/dplatformhandle.h 150 void Dtk::Gui::DPlatformHandle::setFrameMask
include/kernel/dplatformhandle.h 152 void Dtk::Gui::DPlatformHandle::setTranslucentBackground
include/kernel/dplatformhandle.h 153 void Dtk::Gui::DPlatformHandle::setEnableSystemResize
include/kernel/dplatformhandle.h 154 void Dtk::Gui::DPlatformHandle::setEnableSystemMove
include/kernel/dplatformhandle.h 155 void Dtk::Gui::DPlatformHandle::setEnableBlurWindow
include/kernel/dplatformhandle.h 156 void Dtk::Gui::DPlatformHandle::setAutoInputMaskByClipPath

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 820e303 into linuxdeepin:master Aug 13, 2024
20 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Aug 13, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants