Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: add close.dci" #253

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Aug 23, 2024

This reverts commit 12b60a3.

Issue: linuxdeepin/developer-center#10482

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 删除了文件 close.dci,需要确认是否有替代方案处理关闭图标。
  • 修改了 deepin-theme-plugin-icons.qrc 文件中的文件别名,需要检查是否有其他代码依赖于这些别名,以避免潜在的引用错误。

是否建议立即修改:

  • 是,需要确保删除文件 close.dci 后,应用程序仍然能够正常显示关闭图标。
  • 是,需要检查所有引用 deepin-theme-plugin-icons.qrc 中的别名,确保它们在应用程序中仍然正确有效。如果有代码依赖于这些别名,可能会导致运行时错误。

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Aug 23, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#253
@mhduiy mhduiy requested a review from 18202781743 August 23, 2024 07:02
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 23, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@mhduiy mhduiy merged commit 7ec030f into linuxdeepin:master Aug 23, 2024
19 of 21 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Aug 23, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants