Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when follower was destroyed #572

Merged
merged 1 commit into from
May 13, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented May 13, 2024

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request May 13, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#572
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request May 13, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#572
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • QWidget *follower{nullptr};QWidget *target{nullptr};从具体的QWidget指针更改为QPointer<QWidget>,这是一个好的实践,因为它提高了代码的可维护性和灵活性。

是否建议立即修改:

  • 否,因为这个提交中的代码更改看起来是合理的,没有明显的错误或需要立即修复的问题。但是,如果有更多的上下文代码,可能需要进一步的审查来确认是否有其他潜在的问题。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 13, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit e6dd474 into linuxdeepin:master May 13, 2024
17 of 21 checks passed
@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 13, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

kegechen pushed a commit to linuxdeepin/dtk6widget that referenced this pull request May 13, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants