Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obsolete interfaces #606

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

FeiWang1119
Copy link
Contributor

replace obsolete interfaces to compatible to qt6

Log:

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Sep 26, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#606
FeiWang1119 pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Sep 26, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#606
@@ -50,7 +50,7 @@ bool DBounceAnimation::eventFilter(QObject *o, QEvent *e)
if (auto absscroll = dynamic_cast<QAbstractScrollArea *>(o)) {
if (auto wheelEvent = dynamic_cast<QWheelEvent *>(e)) {
if (absscroll->verticalScrollBar()->value() <= 0 || absscroll->verticalScrollBar()->value() >= absscroll->verticalScrollBar()->maximum()) {
d->m_deltaSum += wheelEvent->delta();
d->m_deltaSum += wheelEvent->pixelDelta().x() != 0 ? wheelEvent->pixelDelta().x() : wheelEvent->pixelDelta().y();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加上 QT_VERSION_CHECK 吧

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

replace obsolete interfaces to compatible to qt6

Log:
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DBounceAnimation::eventFilter函数中,对QWheelEventpixelDelta进行了重新计算,这可能是为了处理不同平台之间的兼容性问题。需要确认这一改动是否符合预期行为。
  • ImageLabel类的drawPixmap方法中,使用了pixmap(Qt::ReturnByValue)来获取QPixmap对象,这可能是为了提高性能或避免潜在的内存分配问题。需要验证这一改动是否符合性能要求,并确保不会对现有功能产生负面影响。

是否建议立即修改:

  • 是,需要确保这些更改不会引入新的错误或性能问题。建议在合并代码之前进行彻底的测试,以确保没有潜在的问题。

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Oct 8, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#606
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 8, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@kegechen
Copy link
Contributor

kegechen commented Oct 8, 2024

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 8, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 8397688 into linuxdeepin:master Oct 8, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants