Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: 使用dci icon重绘toolbutton, 增加动画 (#594)" #607

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

FeiWang1119
Copy link
Contributor

This reverts commit 4e5c37c.
Generate binary compatible issue

Log:

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 删除了DToolButtonPrivate类的实现文件dtoolbutton_p.h,可能会影响类的私有成员函数的实现。
  • 移除了DGuiApplicationHelper的依赖,需要确认是否有其他代码处理主题更改。
  • 移除了QEventQKeyEvent的引用,如果其他代码依赖于这些事件,可能会导致问题。
  • 移除了setDciIcon函数的实现,如果其他代码依赖于这个函数,可能会导致问题。

是否建议立即修改:

  • 是,需要确保删除文件后不会影响现有功能,并且不会引入新的问题。需要检查是否有其他代码依赖于这些被移除的功能,并确保它们有相应的替代实现。

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Sep 26, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#607
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 1d82793 into linuxdeepin:master Sep 26, 2024
16 of 21 checks passed
FeiWang1119 pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Sep 26, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants