fix: exit animation of the application disappeared in treeland #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: FeiWang1119 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 23, 2024
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#621
FeiWang1119
force-pushed
the
master
branch
2 times, most recently
from
74a8cb0 to
fb82576
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 23, 2024
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#621
When clicking the close button, call the widget::close. Modify that calling dapplication::quit is the same as clicking the option to exit Log:
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 23, 2024
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#621
deepin pr auto review关键摘要:
是否建议立即修改:
|
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 23, 2024
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#621
18202781743
reviewed
Nov 25, 2024
| @@ -1533,7 +1533,7 @@ void DTitlebar::setVisible(bool visible) | |||
| connect(d->maxButton, SIGNAL(clicked()), this, SLOT(_q_toggleWindowState()), Qt::UniqueConnection); | |||
| connect(this, SIGNAL(doubleClicked()), this, SLOT(_q_toggleWindowState()), Qt::UniqueConnection); | |||
| connect(d->minButton, SIGNAL(clicked()), this, SLOT(_q_showMinimized()), Qt::UniqueConnection); | |||
| connect(d->closeButton, &DWindowCloseButton::clicked, d->targetWindow(), &QWidget::close, Qt::UniqueConnection); | |||
| connect(d->closeButton, SIGNAL(clicked(bool)), this, SLOT(_q_quitActionTriggered()), Qt::UniqueConnection); | |||
There was a problem hiding this comment.
关闭按钮表示退出应用？那对于多窗口的应用是不是有问题呀，像终端这种，关闭一个终端就退出了终端应用了，
There was a problem hiding this comment.
类似终端,文本编辑器都会截获退出事件做处理.
There was a problem hiding this comment.
还是要看看具体原因，是根据什么决定是否有动画？ 退出码？ 还是什么 @justforlxz
There was a problem hiding this comment.
|
TAG Bot New tag: 5.7.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking the close button, call the widget::close.
Modify that calling dapplication::quit is the same as clicking the option to exit
Log: