csd-media-keys: Show device description on volume OSD #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to pass a label to the Cinnamon OSD when a device like headphones are plugged in. Since these outputs each have there own volume level, this makes it easier for a user to identify what they are changing.
clefebvre
added a commit
that referenced
this pull request
Nov 29, 2024
This reverts commit 1dbe86a. It should be obvious to the user which output device is active and interacted with. We only have one set of media keys on the computer. This also always show the device name, even when the computer only has one. This would be useful if we had multiple output devices and multiple sets of media keys (like on a sound mixer for instance), but it's not the case for most people.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to pass a label to the Cinnamon OSD when a device like headphones are plugged in. Since these outputs each have there own volume level, this makes it easier for a user to identify what they are changing.