Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: store a 'latest' assets file in AWS S3 BM-1094 #1008

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

tawera-manaena
Copy link
Contributor

Motivation

As a Basemaps developer, having to look up the path to the most recent assets.tar.co file stored in AWS S3 is inconvenient. It would save me time and effort if a copy of the latest assets file were stored in a fixed location with a fixed name, similar to the bundled config file (config-latest.json.gz).

Context

When I run Basemaps locally, it's not always the case that I can run the basemaps/server package using the config-latest.json.gz file. For example, if I make changes to the vector tile stylesheets and want to test them locally, I need to bundle the config file myself. To do so, I have to specify the --assets parameter to enable fonts, glyphs, and sprites. Otherwise, they will not load on the map.

Solution

Currently, assets files are uploaded to AWS S3 with a hash suffix. Remembering such a hash is unrealistic. It would be ideal if there were an assets-latest.tar.co file stored within the /assets directory, similar to how a config-latest.json.gz file is stored within the /config directory.

s3://linz-basemaps/... Sorted by Last Modified
config/
assets/

Modifications

  1. Updated the build workflow so that it stores a copy of the current assets at the following location in AWS S3:
s3://linz-basemaps/assets/assets-latest.tar.co

@tawera-manaena tawera-manaena requested a review from a team as a code owner October 23, 2024 19:14
@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Oct 24, 2024
Merged via the queue into master with commit 0343c7c Oct 24, 2024
7 checks passed
@Wentao-Kuang Wentao-Kuang deleted the ci/store-latest-assets branch October 24, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants