Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vector): update helipad icon-image symbol BM-1095 #1011

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

tawera-manaena
Copy link
Contributor

@tawera-manaena tawera-manaena commented Nov 7, 2024

Motivation

As a Basemaps user, when I view the Aerial layer with labels enabled, I cannot identify helipad locations like I can when viewing the Topographic layer.

Layer Topographic Aerial (Labels on)
Screenshot
Console (No sprite file errors or warnings)

Sprite files

When we compare the Aeroway-Helipads layer of the topographic.json style to that of the labels.json style. We can see that the two styles reference different sprite files.

Modifications

For both the aerialhybrid.json and labels.json styles, I have updated the icon-image property of the aeroway-Helipads layer to reference the same sprite file (helipad_pnt_fill) as the topographic.json style:

  • aerialhybrid.json

    "icon-image": "helipad_pnt_fill"
  • labels.json

    "icon-image": "helipad_pnt_fill"

Verification

Using the links provided by the github-actions bot, when I preview both the Aerial Hybrid style and the Labels style, I can now identify helipad locations, respectively.

Layer Aerial Hybrid Labels
Screenshot
Console (No sprite file errors or warnings) (No sprite file errors or warnings)

@tawera-manaena tawera-manaena changed the title fix(vector): update helipad icon-image symbol fix(vector): update helipad icon-image symbol BM-1095 Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Vector Style Update

Vector Style updated for st_aerialhybrid

Vector Style updated for st_labels

@tawera-manaena tawera-manaena marked this pull request as ready for review November 8, 2024 01:37
@tawera-manaena tawera-manaena requested a review from a team as a code owner November 8, 2024 01:37
@tawera-manaena tawera-manaena added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 1ddfe91 Nov 11, 2024
7 checks passed
@tawera-manaena tawera-manaena deleted the fix/helipad-icon-image-symbol branch November 11, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants