fix(vector): update helipad icon-image symbol BM-1095 #1011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a Basemaps user, when I view the Aerial layer with labels enabled, I cannot identify helipad locations like I can when viewing the Topographic layer.
Sprite files
When we compare the
Aeroway-Helipads
layer of thetopographic.json
style to that of thelabels.json
style. We can see that the two styles reference different sprite files.topographic.json
The
helipad_pnt_fill
sprite file exists within thesprites/topographic
directory.labels.json
The
heliport_11
andheliport_15
sprite files do not exist within thesprites/topographic
directory.Modifications
For both the
aerialhybrid.json
andlabels.json
styles, I have updated theicon-image
property of theaeroway-Helipads
layer to reference the same sprite file (helipad_pnt_fill
) as thetopographic.json
style:aerialhybrid.json
labels.json
Verification
Using the links provided by the
github-actions
bot, when I preview both the Aerial Hybrid style and the Labels style, I can now identify helipad locations, respectively.