feat(cli): expose the smoke checker in the CLI container so linz/basemaps-config can use it BM-1010 #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maps-config can use it
Wentao-Kuang
approved these changes
Apr 10, 2024
blacha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A configuration change in https://github.com/linz/basemaps-config broke the smoke check tests, It would be nice to run the smoke checker on config changes before deploying them.
Modification
Exposes the smoke checker as a package inside the basemaps/cli container so it can be used by https://github.com/linz/basemaps-config
Checklist
If not applicable, provide explanation of why.