Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(landing): Add terrain parameter in the url #3292

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Jun 19, 2024

Motivation

We want a terrain request parameter that shareable for map with 3d terrain enabled. This will need new aerial style config to added after merge. linz/basemaps-config#916

Modifications

  • Add terrain setting in getStyle api when ?terrain=LINZ-Terrain
  • Update landing page to lisen the terrain event to set terrain parameter.

image

Verification

  • Unit tests added for tileset to style and style to style in getStyle Api
  • Landing page tested with terrain button to update the request parameter.

@Wentao-Kuang Wentao-Kuang marked this pull request as ready for review June 26, 2024 02:51
@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner June 26, 2024 02:51
@Wentao-Kuang Wentao-Kuang requested a review from blacha June 26, 2024 02:51
@blacha blacha enabled auto-merge June 26, 2024 04:39
@blacha blacha added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit 781bbe8 Jun 26, 2024
11 checks passed
@blacha blacha deleted the feat/terrain-url branch June 26, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants