[7777] django upgrade from 3.2.x to 4.2

[m4ra]

Tasks

• PR name contains story or task reference
• Documentation (docs and inline)
• Tests (including n+1 and django_assert_num_queries where applicable)
• Changelog

[goapunk]

LGTM so far, just a small note about the form_valid change

[goapunk]

small note about psycopg

also: do we need to fix the save() method of the models as described here: https://docs.djangoproject.com/en/4.2/releases/4.2/#setting-update-fields-in-model-save-may-now-be-required ?

[goapunk]

some notes:

• the save methods in the vote models haven't been updated, is that on purpose?
• the tests for the servicekonto are now failing. I assume because of the allauth update. We'll have to ask @CarolingerSeilchenspringer about whether we need the servicekonto or nor. Fixing it might be annoying

[m4ra]

some notes:

    the save methods in the vote models haven't been updated, is that on purpose?
    the tests for the servicekonto are now failing. I assume because of the allauth update. We'll have to ask @CarolingerSeilchenspringer about whether we need the servicekonto or nor. Fixing it might be annoying

The votes save() are not called for updating, it's to generate tokens. So they don't need the update_fields.
The servicekonto, took me a while but it's fixed now. I will push soon my changes.
@goapunk

[m4ra]

@goapunk now there is an error with duplicate email constrains, from psycopg for the test that checks signup with existing email. I could inherit from allauth SignUp view/form and handle the exception. But I also tried to bump allauth to latest version, and servicekonto gave new errors. So yes good to ask Caroline, and if the servicekonto is still in use, we need to make it work with latest allauth.

[CarolingerSeilchenspringer]

@goapunk @m4ra talked to client and the service konto in its current form is not used. It may come back but maybe in a whole different technical setting so we can take it out for now.

[goapunk]

@m4ra there is one instance of index_together which should be replaced with indexes as described here: https://docs.djangoproject.com/en/4.2/releases/4.2/#index-together-option-is-deprecated-in-favor-of-indexes

[goapunk]

This was all just hacked together to test, I think having aTopicsSerializer which we add here instead of the function would probably be nice ?

[m4ra]

true

[m4ra]

@goapunk I am changing self to plan for better readability

[goapunk]

looks good to me!